Enable string builtins with SHARED_WASMGC - #27473
Open
tlively wants to merge 1 commit into
Open
Conversation
And also imported string constants. Update every location that compiles a Wasm module to pass the necessary compileOptions.
sbc100
reviewed
Aug 1, 2026
| (call $print_int (call $length (global.get $msg))) | ||
| (call $print_int (call $length (call $fromCharCode (i32.const 65)))) | ||
| ) | ||
| ) |
Collaborator
There was a problem hiding this comment.
I wonder if this could be written in assembly? (Thus avoiding the need to wasm-merge?) If not, I wonder how hard it would be to enable llvm assembly to support this?
Member
Author
There was a problem hiding this comment.
Almost, or even C given that clang nominally supports externrefs. The thing that prevents it from working in this case is that we're using shared externrefs in the import signatures to test the use of strings allocated on the shared heap. Clang definitely doesn't support that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And also imported string constants. Update every location that compiles a Wasm module to pass the necessary compileOptions.